#20565: Fix LinearCode.wtdist_gap method
-------------------------------------+-------------------------------------
Reporter: arpitdm | Owner: arpitdm
Type: defect | Status: needs_work
Priority: minor | Milestone: sage-7.3
Component: coding theory | Resolution:
Keywords: | Merged in:
Authors: Arpit Merchant | Reviewers:
Report Upstream: N/A | Work issues:
Branch: | Commit:
u/arpitdm/fix_wtdist_gap_method | 161a2681636d3139a589aafe64f289d982c54bd6
Dependencies: | Stopgaps:
-------------------------------------+-------------------------------------
Comment (by arpitdm):
1. Deprecation warnings:
Understood. I'm adding the line now.
2. Name and Private:
`AbstractLinearCode.spectrum` computes the spectrum using three algorithms
"binary", "gap" and "leon" each of which is implemented differently.
"binary" imports a function from another file and then calls the
"weight_dist" function from it while "leon" is implemented within
`spectrum`. I think the entire method needs to be refactored so that the
code is more modular.
And so perhaps, the name `weight_distribution is a misnomer. Like Johan
suggests, it should be titled `_spectrum_from_gap` (and so on for the
other two as well).
3. Input to the method:
Agreed. I'll make changes accordingly.
--
Ticket URL: <http://trac.sagemath.org/ticket/20565#comment:9>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at https://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
