#20565: Fix LinearCode.wtdist_gap method
-------------------------------------+-------------------------------------
Reporter: arpitdm | Owner: arpitdm
Type: defect | Status: needs_work
Priority: minor | Milestone: sage-7.3
Component: coding theory | Resolution:
Keywords: | Merged in:
Authors: Arpit Merchant | Reviewers:
Report Upstream: N/A | Work issues:
Branch: | Commit:
u/arpitdm/fix_wtdist_gap_method | 111426739cd1bb4eb395117ff5000d9aafdc23ac
Dependencies: | Stopgaps:
-------------------------------------+-------------------------------------
Comment (by dlucas):
> I've added back the definitions of the local variables such as `F =
self.base_ring()`.
Ok, good!
> The reason to put back `wtdist_gap` as it was, is to allow for users to
get accustomed to the changes, right? That's why we need all the
redirects.
Exactly. In Sage, whenever you change something, you have to be
retrocompatible with the old feature for a year.
> Do we want that `spectrum` also call `wtdist_gap()` which then calls
`_spectrum_from_gap()`? Or can `spectrum` directly call the latter?
`spectrum` can directly call `_spectrum_from_gap`. With all these
deprecation warnings, the general rule is to allow the user to access the
old feature for a year. So, as long as you still provide the old
method/signature/output, replacing the old stuff everywhere else is fine.
> The original wtdist_gap took the generator matrix in a gap string
format. Is it possible to reconvert this representation into a regular
generator matrix from which a linear code can be constructed?
Yup, for instance:
{{{
sage: M = matrix(GF(7), [[1,2,3], [4,5,6]])
sage: Mg = M._gap_()
sage: Ms = Mg._matrix_(GF(7))
sage: Ms == M
True
}}}
--
Ticket URL: <http://trac.sagemath.org/ticket/20565#comment:14>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at https://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
