#20697: Inheritance structure of generic projective/affine curves
-------------------------------------+-------------------------------------
Reporter: gjorgenson | Owner:
Type: enhancement | Status: needs_info
Priority: minor | Milestone: sage-7.3
Component: algebraic | Resolution:
geometry | Merged in:
Keywords: | Reviewers:
Authors: Grayson Jorgenson | Work issues:
Report Upstream: N/A | Commit:
Branch: | 5de70c9c1041a9aea0d4edbb66c43d82ce5bf4ef
u/gjorgenson/ticket/20697 | Stopgaps:
Dependencies: |
-------------------------------------+-------------------------------------
Changes (by bhutz):
* status: needs_review => needs_info
Comment:
I do not see anything wrong with the new inheritance structure, but I
don't really understand the naming conventions of the classes. Here is
what I see
AffineSpaceCurve, ProjectiveSpaceCurve = the generic curves classes
AffineCurve_generic, ProjectiveCurve_generic - the curves that must lie in
the plane (A2 or P2).
That seems somewhat odd to me. If I've understood this correctly doesn't
some naming convention like
AffineCurve_generic, ProjectiveCurve_generic -> XXXXCurve_plane
AffineSpaceCurve, ProjectiveSpaceCurve -? XXXXCurve_generic
make more sense. Then the special class inherits from the 'generic' class
instead of the other way around.
Also, it seems like some description should be added to the documentation
for all of these classes.
--
Ticket URL: <http://trac.sagemath.org/ticket/20697#comment:4>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at https://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
