#20744: Polynomial encoder for GRS codes fails if variable name is not x
-------------------------------------+-------------------------------------
Reporter: dlucas | Owner:
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-7.3
Component: coding theory | Resolution:
Keywords: | Merged in:
Authors: | Reviewers:
Report Upstream: N/A | Work issues:
Branch: | Commit:
u/dlucas/grs_polynomial_encoder_msg_space_fix|
7692498a270d5847ff5987a91f9d4afe30696578
Dependencies: | Stopgaps:
-------------------------------------+-------------------------------------
Comment (by jsrn):
Replying to [comment:6 dlucas]:
> I did what we talked about, and added related input checks and `TESTS`
block.
Cool. You also need a check that `polynomial_ring.base_ring()` is the
field of the code.
> This method `polynomial_ring` feels like code duplication with
`message_space`, but it makes sense to provide it, so even if it's not
über-clean, I can live with that.
Yes, that's why I suggested making it an "alias of `message_space`". But
now you've made a full function anyway. However, can you add in the doc-
string that this is the same as the message space?
--
Ticket URL: <http://trac.sagemath.org/ticket/20744#comment:7>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at https://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
