#13055: Refactor numerical_approx()
-------------------------------------+-------------------------------------
       Reporter:  dsm                |        Owner:  burcin
           Type:  enhancement        |       Status:  needs_review
       Priority:  minor              |    Milestone:  sage-7.3
      Component:  basic arithmetic   |   Resolution:
       Keywords:  numerical_approx,  |    Merged in:
  sd40.5, days74                     |    Reviewers:
        Authors:  Jeroen Demeyer     |  Work issues:
Report Upstream:  N/A                |       Commit:
         Branch:                     |  fafdb9c02ad5b9d0c7d85fe3cc4468015d08fd68
  u/jdemeyer/document_default_precision_for__n___method|     Stopgaps:
   Dependencies:                     |
-------------------------------------+-------------------------------------

Comment (by mmezzarobba):

 Most of the changes look good to me, but I don't like the new description
 of `RealLiteral.numerical_approx()`: as far as I understand “real
 literals” are exact decimal numbers, so converting one to a `RealField`
 element with d·log₁₀ 2 bits of precision doesn't really “change its
 precision” to d decimal digits.

 And—just wondering, I have nothing against that choice—is there a reason
 why you didn't put the generic implementation directly in `Element` (and
 put code to convert non-Elements to Elements before calling it when
 necessary)?

--
Ticket URL: <http://trac.sagemath.org/ticket/13055#comment:24>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at https://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.

Reply via email to