#20749: Use PARI nfeltup() for inclusion of base field into relative number
field
-------------------------------------+-------------------------------------
Reporter: pbruin | Owner:
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-7.3
Component: number fields | Resolution:
Keywords: relative number | Merged in:
field pari | Reviewers: Stephan Ehlen
Authors: Peter Bruin | Work issues:
Report Upstream: N/A | Commit:
Branch: | 9f1d90be8d3f05b6d5de8ee75e36e6d17ad52095
u/pbruin/20749-pari_nfeltup | Stopgaps:
Dependencies: |
-------------------------------------+-------------------------------------
Comment (by pbruin):
Replying to [comment:5 ehlen]:
> I started to review your changes. So far I can confirm that this does
what it's supposed to do (see some timings below) but there seem to be
some negative side-effects on the creation of relative extension.
> [...]
> The call to {{{'_nf_nfzk'}}} is now the main contributor and creating
the extension is almost 12 times slower.
> @pbruin: Do you think we can avoid slowing down the creation of
extensions somehow?
See #20759; we can postpone the call to `_nf_nfzk`, but we should do it at
the latest when first mapping an element of the base field into the
relative field, since there is no way to predict how often this is going
to be done.
--
Ticket URL: <http://trac.sagemath.org/ticket/20749#comment:7>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at https://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
