#20758: Simplicial complexes: keep the __enlarged cache in add_face
-------------------------------------+-------------------------------------
Reporter: jhpalmieri | Owner:
Type: enhancement | Status: needs_review
Priority: minor | Milestone: sage-7.3
Component: algebraic | Resolution:
topology | Merged in:
Keywords: | Reviewers:
Authors: | Work issues:
Report Upstream: N/A | Commit:
Branch: u/jhpalmieri | 1f18ca90a8b1574cf2d8f1de6cbc2bdaa161c39a
/simplicial-add-face | Stopgaps:
Dependencies: |
-------------------------------------+-------------------------------------
Changes (by jhpalmieri):
* status: new => needs_review
* commit: => 1f18ca90a8b1574cf2d8f1de6cbc2bdaa161c39a
* branch: => u/jhpalmieri/simplicial-add-face
Old description:
> The `add_face` method currently deletes the ``__enlarged`` cache, but
> this is unnecessary.
New description:
The `add_face` method currently deletes the {{{__enlarged}}} cache, but
this is unnecessary.
--
Comment:
The {{{_faces}}} cache was also not treated properly, in both `add_face`
and `remove_face`. For `add_face`, for example, you can see this if
instead of the change here, you just delete the line {{{self.__enlarged =
{}}}}: a doctest will fail because of an incorrect homology calculation,
because of the wrong cached value for {{{_faces}}}.
----
New commits:
||[http://git.sagemath.org/sage.git/commit/?id=1f18ca90a8b1574cf2d8f1de6cbc2bdaa161c39a
1f18ca9]||{{{Simplicial complexes: when adding a face, keep the __enlarged
cache.}}}||
--
Ticket URL: <http://trac.sagemath.org/ticket/20758#comment:1>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at https://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
