#20758: Simplicial complexes: keep the __enlarged cache in add_face
-------------------------------------+-------------------------------------
Reporter: jhpalmieri | Owner:
Type: enhancement | Status: needs_work
Priority: minor | Milestone: sage-7.3
Component: algebraic | Resolution:
topology | Merged in:
Keywords: days74 | Reviewers: Travis Scrimshaw
Authors: John Palmieri | Work issues:
Report Upstream: N/A | Commit:
Branch: | c7bdbcf797859670d9bcb0ce29c7692ea0832f2d
u/jhpalmieri/simplicial_add_face-20758| Stopgaps:
Dependencies: |
-------------------------------------+-------------------------------------
Changes (by vbraun):
* status: needs_review => needs_work
Comment:
{{{
sage -t --long src/sage/homology/simplicial_complex.py
**********************************************************************
File "src/sage/homology/simplicial_complex.py", line 2606, in
sage.homology.simplicial_complex.SimplicialComplex.remove_face
Failed example:
T.remove_face((1,2,3))
Exception raised:
Traceback (most recent call last):
File "/Users/buildslave-
sage/slave/sage_git/build/local/lib/python2.7/site-
packages/sage/doctest/forker.py", line 498, in _run
self.compile_and_execute(example, compiler, test.globs)
File "/Users/buildslave-
sage/slave/sage_git/build/local/lib/python2.7/site-
packages/sage/doctest/forker.py", line 861, in compile_and_execute
exec(compiled, globs)
File "<doctest
sage.homology.simplicial_complex.SimplicialComplex.remove_face[12]>", line
1, in <module>
T.remove_face((Integer(1),Integer(2),Integer(3)))
File "/Users/buildslave-
sage/slave/sage_git/build/local/lib/python2.7/site-
packages/sage/homology/simplicial_complex.py", line 2659, in remove_face
if L is None or Simplex(face) not in L:
File "/Users/buildslave-
sage/slave/sage_git/build/local/lib/python2.7/site-
packages/sage/homology/simplicial_complex.py", line 1204, in __contains__
return x in self.faces()[dim]
KeyError: 2
**********************************************************************
File "src/sage/homology/simplicial_complex.py", line 2607, in
sage.homology.simplicial_complex.SimplicialComplex.remove_face
Failed example:
len(T._faces)
Expected:
2
Got:
1
**********************************************************************
1 item had failures:
2 of 17 in
sage.homology.simplicial_complex.SimplicialComplex.remove_face
[581 tests, 2 failures, 6.66 s]
}}}
--
Ticket URL: <http://trac.sagemath.org/ticket/20758#comment:10>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at https://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
