#20731: shortcut coercion for Integer-Rational operations
-------------------------------------+-------------------------------------
       Reporter:  vdelecroix         |        Owner:
           Type:  enhancement        |       Status:  needs_work
       Priority:  major              |    Milestone:  sage-7.3
      Component:  coercion           |   Resolution:
       Keywords:  sd74               |    Merged in:
        Authors:  Vincent Delecroix  |    Reviewers:
Report Upstream:  N/A                |  Work issues:
         Branch:                     |       Commit:
  u/vdelecroix/20731                 |  675f8e617bdcc66e718d18089938b8d1458d0724
   Dependencies:                     |     Stopgaps:
-------------------------------------+-------------------------------------
Changes (by jdemeyer):

 * status:  needs_review => needs_work


Comment:

 Some ---hopefully final--- notes:

 1. Check documentation (for example, `Rational.__sub__` documents plus)

 2. In `mpq_div_z`, you do not need to check the sign since the denominator
 is the product of two denominators, so it must be positive.

 3. I would remove functions `mpq_sub_z` and `mpq_div_z` since they do not
 commute and are less useful: just implement them directly. Then you can
 also avoid `mpq_neg` and `mpq_inv` if you do it correctly.

--
Ticket URL: <http://trac.sagemath.org/ticket/20731#comment:28>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at https://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.

Reply via email to