#20780: add level parameter to rational_preimages for projective points
-------------------------------------+-------------------------------------
Reporter: bhutz | Owner: bhutz
Type: enhancement | Status: needs_review
Priority: minor | Milestone: sage-7.3
Component: algebraic | Resolution:
geometry | Merged in:
Keywords: | Reviewers: Grayson Jorgenson
Authors: Ben Hutz | Work issues:
Report Upstream: N/A | Commit:
Branch: u/bhutz/t/20780 | e7db093e5e6d70000c9806e1555cb09ce579e997
Dependencies: | Stopgaps:
-------------------------------------+-------------------------------------
Changes (by gjorgenson):
* reviewer: => Grayson Jorgenson
Comment:
I think this looks good. The code makes sense and appears to work as
intended. I just found some really minor things:
-algebraic_scheme.py
- line 2780 - change TypeError message to all lowercase
- Old issues present before this ticket that maybe could be addressed
here:
- line 2680 - {{{`False`}}} to {{{``False``}}}
- line 2711 - some spacing in ProjectiveSpace calls and in lists of
defining polynomials
-projective_homset.py
- line 182 - the sorted() function takes any iterable and returns a list,
so it shouldn't be necessary to convert rat_points to a list first
-projective_morphism.py
- line 3920 spacing around '>'
- lines 3790 - 3793, formatting issues: {{{``k``th}}} and {{{`k`th}}}
don't seem to render well, and perhaps
{{{`P`}}} and {{{`Q`}}} should be replaced with {{{``P``}}},
{{{``Q``}}}.
- some ProjectiveSpace calls in examples of rational_preimages don't have
any spacing in the arguments
--
Ticket URL: <http://trac.sagemath.org/ticket/20780#comment:2>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at https://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
