#20705: Classes for Reed Muller Codes
-------------------------------------+-------------------------------------
Reporter: panda314 | Owner:
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-7.3
Component: coding theory | Resolution:
Keywords: | Merged in:
Authors: Parthasarathi | Reviewers: David Lucas
Panda | Work issues:
Report Upstream: N/A | Commit:
Branch: | 13cda90026b28644ed1c018d7628ea1e007cd4ef
u/dlucas/classes_for_reed_muller_codes| Stopgaps:
Dependencies: |
-------------------------------------+-------------------------------------
Comment (by jsrn):
I know I'm late to the scene, but I have a few questions/comments:
1. Why are lines 249--255 in reed_muller_code.py formatted so badly?
Similarly for line 70--75. This type of formatting is not PEP8, I believe.
1. The patch in `linear_code.py` adding `Integer` around `n-k` shouldn't
be necessary: `n` is `C.length()` and `k` is `C.dimension()`. Both should
*always* return `Integer`. You should find the example that led you to
make this patch and instead fix the root cause that made either `n` or `k`
rational. Incidentally, I think I know where the bug is: your
`_binomial_sum` returns a rational since you have a division that you
don't cast to `Integer`. Amusingly, that cast seems to speed up
`_binomial_sum` by a factor 3 or so.
1. Could you please improve the docstring of `order()` with a second
sentence explaining what the order is? The current docstring is the type
of infuriatingly unhelpful docstrings that are way too common ;-)
1. Same for `number_of_variables` and `minimum_distance`. Yes, I am aware
that there are code classes with similarly unhelpful docstrings, but let's
try to improve Sage :-)
1. For `__repr__` etc., perhaps it be more consistent with Reed--Solomon
codes to write something like "Reed-Muller of order X in Y variables over
`self.base_field()`".
--
Ticket URL: <http://trac.sagemath.org/ticket/20705#comment:31>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at https://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
