#20705: Classes for Reed Muller Codes
-------------------------------------+-------------------------------------
Reporter: panda314 | Owner:
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-7.3
Component: coding theory | Resolution:
Keywords: | Merged in:
Authors: Parthasarathi | Reviewers: David Lucas
Panda | Work issues:
Report Upstream: N/A | Commit:
Branch: | 13cda90026b28644ed1c018d7628ea1e007cd4ef
u/dlucas/classes_for_reed_muller_codes| Stopgaps:
Dependencies: |
-------------------------------------+-------------------------------------
Comment (by jsrn):
22. In `ReedMullerVectorEncoder.generator_matrix`, you should iterate
directly over `exponents`: `for exponent in exponents: ...`.
1. In `ReedMullerVectorEncoder.generator_matrix` and other places, perhaps
`base_field_tuple` should simply be called `points`.
1. There should be a method to get the list of points used for evaluation.
1. I don't think `ReedMullerVectorEncoder.generator_matrix` is correct:
you are indexing in the point `x` using `exponent`. But you *should* be
computing `prod_{i=1}^m x[i]^exponent[i]`. Using `reduce(mul,...)` in this
instance is less clear than using `prod(...)`.
1. In doc for `ReedMullerPolynomialEncoder` it says "polynomial field",
but it should be "polynomial ring". It should say that `polynomial_ring`
is optional.
1. Copy-paste error: it says something about `If code is not GRS code
...`.
1. The polynomial in the example of `ReedMullerPolynomialEncoder.encode`
is badly formatted.
1. The failing example of `ReedMullerPolynomialEncoder.encode` with poly
of too high degree could be with a poly where each variable has OK degree,
but the total degree is bad, e.g. `x0^2*x1`.
Otherwise, good job! Don't worry about the volume of my comments. David
has fond memories of tickets where I similarly put him through the wringer
;-)
Best,
Johan
--
Ticket URL: <http://trac.sagemath.org/ticket/20705#comment:34>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at https://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
