#20636: Add pictures to contour_plot.py
-------------------------------------+-------------------------------------
       Reporter:  jhonrubia6         |        Owner:
           Type:  enhancement        |       Status:  needs_review
       Priority:  minor              |    Milestone:  sage-7.3
      Component:  documentation      |   Resolution:
       Keywords:                     |    Merged in:
        Authors:  Javier Honrubia    |    Reviewers:  Travis Scrimshaw,
  González                           |  Paul Masson
Report Upstream:  N/A                |  Work issues:
         Branch:                     |       Commit:
  u/jhonrubia6/add_pictures_to_contour_plot_py|  
13320c7b18fc1a8a2e5e8c529674b1488439e4fd
   Dependencies:                     |     Stopgaps:
-------------------------------------+-------------------------------------
Changes (by tscrim):

 * reviewer:   => Travis Scrimshaw, Paul Masson


Comment:

 Sorry this fell off my radar. This looks good, except for this one:
 {{{#!diff
 -    f = [equify(g) for g in f if not (is_Expression(g) and g.operator()
 is operator.eq)]
 +    f = [equify(g)
 +         for g in f if not (is_Expression(g) and g.operator() is
 operator.eq)]
 }}}
 although I don't really care about this. @paulmasson I do agree that more
 consistency would be good (and a space between arguments of functions). I
 will leave it up to you if you want to have these changes in this ticket
 or to set it to a positive review as-in.

--
Ticket URL: <https://trac.sagemath.org/ticket/20636#comment:11>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at https://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.

Reply via email to