#20636: Add pictures to contour_plot.py
-------------------------------------+-------------------------------------
Reporter: jhonrubia6 | Owner:
Type: enhancement | Status: needs_review
Priority: minor | Milestone: sage-7.3
Component: documentation | Resolution:
Keywords: | Merged in:
Authors: Javier Honrubia | Reviewers: Travis Scrimshaw,
González | Paul Masson
Report Upstream: N/A | Work issues:
Branch: | Commit:
u/jhonrubia6/add_pictures_to_contour_plot_py|
6d1b00be8b81e039af630c0e7682ee04fc9fa60b
Dependencies: | Stopgaps:
-------------------------------------+-------------------------------------
Comment (by paulmasson):
Since PEP8 is about appearance of code and not meaning, I wouldn't worry
about that. For the specific example you ask, I would close the white
space both in the tuple and in the xsrange.
When I recommended have a space between arguments of functions, I should
have been more specific and said that should apply to the right-hand side
with many arguments. I see you changed `f(x,y)` to `f(x, y)` consistently
on left-hand sides, but if it's not too much trouble I would ask you to
change that back by omitting the space.
You've gotten most of the other things I saw, except there are three cases
where `),plot_points` should be `), plot_points` and two cases where
`),fill` should be `), fill`.
Also, the one plot with
{{{
contour_plot(x^2-y^3+10*sin(x*y),
+ ....: (x,-4,4),
+ ....: (y,-4,4),
+ ....: plot_points=121, cmap='hsv')
}}}
would look better
{{{
contour_plot(x^2-y^3+10*sin(x*y), (x,-4,4), (y,-4,4),
+ ....: plot_points=121, cmap='hsv')
}}}
With those changes I'll stop being so picky! Thanks for the patience.
--
Ticket URL: <https://trac.sagemath.org/ticket/20636#comment:15>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at https://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
