#20214: Type inconsistencies in polynomial factorization
-------------------------------------+-------------------------------------
Reporter: vdelecroix | Owner:
Type: defect | Status: needs_review
Priority: major | Milestone: sage-7.3
Component: algebra | Resolution:
Keywords: | Merged in:
Authors: Vincent Delecroix | Reviewers:
Report Upstream: N/A | Work issues:
Branch: | Commit:
u/vdelecroix/20214 | ee6ac003dfcfd5fbc53cb83f42c6e094a45d59d3
Dependencies: | Stopgaps:
-------------------------------------+-------------------------------------
Comment (by vdelecroix):
Replying to [comment:17 mmarco]:
> Some questions after a first quick look.
>
> Why in this part of the code,
>
> {{{...}}}
>
> we don't include this first attempt?:
>
> {{{...}}}
>
Right. It can be simplified a bit.
> In the neg method we only allow negation of factorizations with unit
(from what I have seen, it could happen in parents with no one method, and
that doesn't allow to convert 1, not sure if they exist).
Right, there is a problem here. What should we do for `-fac` when there is
no unit? Raise an error?
> Otherwise it looks ok, but I still have to test it a bit more deeply.
Thanks for looking at it!
--
Ticket URL: <https://trac.sagemath.org/ticket/20214#comment:18>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at https://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
