#18555: Pickling and otherwise enhancing global options
-------------------------------------+-------------------------------------
Reporter: andrew.mathas | Owner:
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-6.8
Component: interfaces | Resolution:
Keywords: days78, options | Merged in:
Authors: Andrew Mathas | Reviewers:
Report Upstream: N/A | Work issues:
Branch: | Commit:
public/misc/pickling_global_options-18555|
f42beb4a800cf4fd9c07acfbd054fd91b896edb2
Dependencies: | Stopgaps:
-------------------------------------+-------------------------------------
Changes (by tscrim):
* keywords: options => days78, options
* commit: 11b7080fb16f62f64d39bca2286d0912c55a2125 =>
f42beb4a800cf4fd9c07acfbd054fd91b896edb2
* status: new => needs_review
* branch: u/andrew.mathas/pickling_global_options =>
public/misc/pickling_global_options-18555
Comment:
Okay, I fixed the doctest failures with `permutation.py`. The issue was
that the `_Option` (now `Option` so it appears in the doc) did not define
a `__ne__` method, and so it returned `True` for things like `opt != X`
even when `opt == X`.
The other doctest failures were due to lack of conversion to `options`
from `global_options`.
This is a very nice improvement over the current interface to (global)
options. If the doctest pass for you and my changes are good, then you can
set this to a positive review.
----
New commits:
||[https://git.sagemath.org/sage.git/commit?id=0636c87363f225dffe3c899a7469dc6a52ae543d
0636c87]||{{{Merge branch 'u/andrew.mathas/pickling_global_options' of
trac.sagemath.org:sage into public/misc/pickling_global_options-18555}}}||
||[https://git.sagemath.org/sage.git/commit?id=9642057dcc814a815f526849427772130b07493f
9642057]||{{{Making everything work with the new API.}}}||
||[https://git.sagemath.org/sage.git/commit?id=f42beb4a800cf4fd9c07acfbd054fd91b896edb2
f42beb4]||{{{Rename _Option to Option and some PEP8 to
global_options.py.}}}||
--
Ticket URL: <https://trac.sagemath.org/ticket/18555#comment:13>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at https://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
