#18555: Pickling and otherwise enhancing global options
-------------------------------------+-------------------------------------
       Reporter:  andrew.mathas      |        Owner:
           Type:  enhancement        |       Status:  needs_review
       Priority:  major              |    Milestone:  sage-7.3
      Component:  interfaces         |   Resolution:
       Keywords:  days78, options    |    Merged in:
        Authors:  Andrew Mathas      |    Reviewers:
Report Upstream:  N/A                |  Work issues:
         Branch:                     |       Commit:
  public/misc/pickling_global_options-18555|  
3f5e0e91e2289dcee18ad56b30c6884f9d26c890
   Dependencies:                     |     Stopgaps:
-------------------------------------+-------------------------------------
Changes (by tscrim):

 * milestone:  sage-6.8 => sage-7.3


Comment:

 `Reset()` breaks python conventions, so that is a -1 from me. I think
 `reset()` or `_reset()` are both fine. Yet there is not so much a good
 general reason to go back to defaults other than for testing purposes in
 my mind. Hence the hidden `_reset()` is better IMO.

 One last thing, you added an `__init__` method in `interval_poset.py`. Is
 this necessary? If so, it needs a doctest. Once this is done, this will be
 at a positive review.

--
Ticket URL: <https://trac.sagemath.org/ticket/18555#comment:18>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at https://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.

Reply via email to