#19339: Use digraph labels if present for ClusterAlgebra and ClusterQuiver
-------------------------------------+-------------------------------------
Reporter: aram.dermenjian | Owner:
Type: enhancement | Status: needs_work
Priority: minor | Milestone: sage-6.9
Component: algebra | Resolution:
Keywords: cluster, cluster | Merged in:
algebra, quiver, cluster quiver |
Authors: aram.dermenjian | Reviewers:
Report Upstream: N/A | Work issues:
Branch: | Commit:
u/benstrasser/use_digraph_labels_if_present_for_clusteralgebra_and_clusterquiver|
5ccae7c18f22da1984725e5d72d1ffc2b9d7adc4
Dependencies: | Stopgaps:
-------------------------------------+-------------------------------------
Changes (by {'newvalue': u'aram.dermenjian', 'oldvalue': ''}):
* status: needs_review => needs_work
* author: => aram.dermenjian
Comment:
Hi Ben,
These are my suggestions for now:
* In the doc for `ClusterQuiver` taking digraph as input, could you add
another line `sage: for Q.nlist()` so the user will read that
`ClusterQuiver` will remember labels from the input digraph.
* The following bug does not exist before this ticket was pulled:
{{{
sage: Q=ClusterQuiver(DiGraph([[0,5]]))
sage: Q.b_matrix()
[ 0 1]
[-1 0]
sage: Q.mutate(0)
IndexError: index out of range
}}}
* Also, I think we should either explain the following behavior in the
doc, or change the code so that the behavior for `mutation` is more
consistent. I think either is fine. The following works well
{{{
sage: S=ClusterSeed(DiGraph([['a','b']]))
sage: S.mutate('a')
}}}
but the following throws an error
{{{
sage: S=ClusterSeed(DiGraph([[5,'b']]))
sage: S.mutate(5)
ValueError: The quiver can only be mutated at a vertex or at a sequence of
vertices
}}}
* If possible, could you get the recent version of Sage (if not 7.3beta 6,
then at least 7.2 master branch), and then add your code on top of this
recent Sage? Currently your branch is marked as red because it cannot
automatically merge.
--
Ticket URL: <https://trac.sagemath.org/ticket/19339#comment:23>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at https://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
