#19339: Use digraph labels if present for ClusterAlgebra and ClusterQuiver
-------------------------------------+-------------------------------------
Reporter: aram.dermenjian | Owner:
Type: enhancement | Status: needs_work
Priority: minor | Milestone: sage-6.9
Component: algebra | Resolution:
Keywords: cluster, cluster | Merged in:
algebra, quiver, cluster quiver | Reviewers: Aram Dermenjian,
Authors: Ben Strasser | Emily Gunawan
Report Upstream: N/A | Work issues:
Branch: | Commit:
u/benstrasser/19339 | 1aabf461525ff0bcd21b180126b139fb3d3659b7
Dependencies: | Stopgaps:
-------------------------------------+-------------------------------------
Comment (by tscrim):
Some quick comments:
- I believe you want `user_labels` to be a list, so once we switch to
Python3, the current code won't work. So I recommend (and is also faster):
{{{
user_labels = [ZZ(x) if type(x) == int else x for x in user_labels]
}}}
- Instead of `elif type(user_labels[i]) in [list,tuple]:`, you should use
`elif isinstance(user_labels[i], (list, tuple)):` (unless you want to
explicitly forbid any subclasses of `list` or `tuple`).
- Python uses different conventions than, e.g., C++/Java. So variables
`isVertices` should be `is_vertices`.
- You have an erroneous character:
{{{#!diff
For the compendium on the cluster algebra and quiver package see ::
-
+f
http://arxiv.org/abs/1102.4844.
}}}
--
Ticket URL: <https://trac.sagemath.org/ticket/19339#comment:26>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at https://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
