#20951: Fix Relative Field Extensions
-------------------------------------+-------------------------------------
Reporter: jlavauzelle | Owner:
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-7.3
Component: coding theory | Resolution:
Keywords: | Merged in:
Authors: Julien Lavauzelle | Reviewers: David Lucas
Report Upstream: N/A | Work issues:
Branch: | Commit:
u/dlucas/fix_relative_field_extensions|
2510d2b1312fb795aa59c67c90d4fd887598ddcf
Dependencies: | Stopgaps:
-------------------------------------+-------------------------------------
Changes (by dlucas):
* reviewer: => David Lucas
* commit: 17bf28d79ec2461412f83397bf2930bd7e6bfd1c =>
2510d2b1312fb795aa59c67c90d4fd887598ddcf
Comment:
Hello,
I made two small changes:
- There was an indentation error in the docstring of
`cast_into_relative_field`, which I fixed.
- In Python, it's not necessary to write `if (check):`, `if check:` is
enough `:)`. Thus I removed the unnecessary parenthesis.
Otherwise, it's good to go! If you agree with my tiny changes, you can set
it to `positive_review`.
Thanks for your fixes.
BTW, the patchbot doctests error due to `guava.py` have been fixed in
#20952.
Best,
David
----
New commits:
||[https://git.sagemath.org/sage.git/commit?id=6ace61b17485c5383153e8787de611b85a07adda
6ace61b]||{{{Fixed small bug in documentation}}}||
||[https://git.sagemath.org/sage.git/commit?id=2510d2b1312fb795aa59c67c90d4fd887598ddcf
2510d2b]||{{{Removed unnecessary parenthesis}}}||
--
Ticket URL: <https://trac.sagemath.org/ticket/20951#comment:8>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at https://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
