#20998: convert _cmp_ to __richcmp__ in some pyx files
-------------------------+-------------------------------------------------
Reporter: | Owner:
chapoton |
Type: | Status: needs_work
enhancement |
Priority: major | Milestone: sage-7.3
Component: | Resolution:
python3 |
Keywords: | Merged in:
Authors: | Reviewers:
Frédéric Chapoton |
Report Upstream: N/A | Work issues:
Branch: | Commit:
public/20998 | f4d65c76e96648ce0b1e0bd17122a3eec6bce18f
Dependencies: | Stopgaps:
-------------------------+-------------------------------------------------
Comment (by jdemeyer):
Replying to [comment:11 chapoton]:
> Do you have useful concrete suggestions ? For example
> {{{
> git grep -P -c "cmp\(type" *.pyx
> }}}
> return something like 25 instances. What to do with them ?
It depends where you find those `cmp(typeA, typeB)`. If it's within a `def
__cmp__` method, then that should be cleaned up anyway. If it's somewhere
else, I guess the code should be refactored to not compare types (why
would you do that anyway?).
--
Ticket URL: <https://trac.sagemath.org/ticket/20998#comment:12>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at https://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.