#20998: Removing deprecated cmp and __cmp__ in some pyx files
-------------------------+-------------------------------------------------
Reporter: | Owner:
chapoton |
Type: | Status: needs_work
enhancement |
Priority: major | Milestone: sage-7.3
Component: | Resolution:
python3 |
Keywords: | Merged in:
Authors: | Reviewers: Jeroen Demeyer
Frédéric Chapoton |
Report Upstream: N/A | Work issues:
Branch: | Commit:
public/20998 | 0e819d2704eb9ff6a5287ae200fe65470cf9d011
Dependencies: | Stopgaps:
-------------------------+-------------------------------------------------
Comment (by jdemeyer):
Replying to [comment:26 chapoton]:
> Thanks.
>
> I have tried to make changes for your point 2.
Looks good.
> Do you suggest that in these 3 files I should replace double-underscored
`__richcmp__` methods by single-underscored `_richcmp_` methods, and at
the same time remove the check for type equality ?
Hard to tell in general because one really needs to understand what the
various classes do and which kind of objects you would like to compare.
For `FreeAlgebraElement_letterplace` and `LeftZeroSemigroupElement`, the
answer to your question is probably "YES", for `FormalCompositeMap` it
might be "NO".
--
Ticket URL: <https://trac.sagemath.org/ticket/20998#comment:27>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at https://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
