#20611: More functions for mq.SBox and helper to build a Feistel/MISTY
constructed
S-Box
-------------------------------------+-------------------------------------
Reporter: ruhm | Owner:
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-7.3
Component: cryptography | Resolution:
Keywords: | Merged in:
Authors: | Reviewers:
Report Upstream: N/A | Work issues:
Branch: | Commit:
u/ruhm/improved_sbox | fe51c7638537aeeec9de469357c03ed8ae63fc8c
Dependencies: | Stopgaps:
-------------------------------------+-------------------------------------
Comment (by ruhm):
Hi Martin,
Thanks for looking at this. I should have asked this before, but can you
point out at which lines you see such issue ? This makes me a bit confuse
before.
Thanks,
Replying to [comment:14 malb]:
> Looks good except for
>
> > You sometimes write "Return True" and sometimes write "Return `True`"
>
> I'm happy to give this a positive review after this is fixed. Sorry for
being nitpicky, but these things hardly get fixed afterwards.
--
Ticket URL: <https://trac.sagemath.org/ticket/20611#comment:15>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at https://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
