#5891: Categories for the working mathematics programmer
---------------------------+------------------------------------------------
Reporter: nthiery | Owner: nthiery
Type: enhancement | Status: needs_work
Priority: major | Milestone: sage-combinat
Component: misc | Keywords: categories parents
Work_issues: | Author:
Reviewer: | Merged:
---------------------------+------------------------------------------------
Changes (by was):
* status: new => needs_work
Comment:
NOTES:
(1) Post the latest version here -- I don't want to mess with the patch
server.
(2) It says "Experts: please redefine this properly and/or put CC/RR/...
in NumberFields()". I number field is by definition a finite extension of
QQ, but CC and RR are infinite extensions of QQ. So we can't put them in
that category. Having a function is_NumberFieldHomsetCodomain does seem
like a good workaround for now.
(3) The function is_NumberFieldHomsetCodomain in the patch posted here
doesn't have any documentation or doctests. Please add them.
(4) I would change these two lines:
{{{
143 if is_Field(codomain):
144 return True
}}}
to the single line
{{{
143 return is_Field(codomain)
}}}
which should be functionally the same, and clearer to read.
(5) in a similar spirit, I would change
{{{
145 except:
146 pass
147 return False
}}}
to just
{{{
145 except:
146 return False
}}}
which is again clearer and equivalent.
(6) I'm puzzled by this in your number_field_rel.py patch:
{{{
543 return NotImplemented
}}}
What is NotImplemented? It's not defined in the number_field_rel.py file
in sage-4.2.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/5891#comment:17>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to
[email protected]
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en
-~----------~----~----~----~------~----~------~--~---
