#5891: Categories for the working mathematics programmer
---------------------------------------------------------------------------------------------------------+
   Reporter:  nthiery                                                           
                         |       Owner:  nthiery           
       Type:  enhancement                                                       
                         |      Status:  needs_review      
   Priority:  major                                                             
                         |   Milestone:  sage-combinat     
  Component:  misc                                                              
                         |    Keywords:  categories parents
Work_issues:                                                                    
                         |      Author:  Nicolas M. Thiéry 
   Reviewer:  Robert Bradshaw, Florent Hivert, David Kohel, David Roe, Anne 
Schilling, Javier Vengoroso  |      Merged:                    
---------------------------------------------------------------------------------------------------------+
Changes (by newvalueoldvalue):

  * status:  needs_work => needs_review
  * reviewer:  => Robert Bradshaw, Florent Hivert, David Kohel, David Roe,
               Anne Schilling, Javier Vengoroso
  * author:  => Nicolas M. Thiéry


Old description:

> This (series of) patch(es) extends the Sage category framework as a
> design pattern for organizing generic code.
>
>  - Latest version of the patches:
>
>    - [http://combinat.sagemath.org/patches/file/tip/categories-framework-
> nt.patch]          (reviewer: David Roe; review essentially complete up
> to some doctests)
>    - [http://combinat.sagemath.org/patches/file/tip/categories-
> categories-nt.patch]         (reviewer: Florent Hivert, Javier, David
> Kohel, Anne Schilling, ...) See CategoriesCategoriesReview
>    - [http://combinat.sagemath.org/patches/file/tip/categories-
> fixsagelib-nt.patch]         (positive review: Robert Bradshaw)
>    updates to the sage library (import fixes, ...)
>    - [http://combinat.sagemath.org/patches/file/tip/categories-fix-
> combinat-nt.patch]       (positive review: Florent)
>    - [http://combinat.sagemath.org/patches/file/tip/categories-
> numberfield_homset-nt.patch] (reviewer: David)
>    - [http://combinat.sagemath.org/patches/file/tip/categories-
> unpickle_backward_compatibility_aliases-nt.patch] (positive review:
> Florent)
>

>  - Status and roadmap:
> http://sagetrac.org/sage_trac/wiki/CategoriesRoadMap

New description:

 This (series of) patch(es) extends the Sage category framework as a
 design pattern for organizing generic code.

  - Latest version of the patches:

    - [http://combinat.sagemath.org/patches/file/tip/categories-framework-
 nt.patch]          (reviewer: David Roe; review essentially complete up to
 some doctests)
    - [http://combinat.sagemath.org/patches/file/tip/categories-categories-
 nt.patch]         (reviewer: Florent Hivert, Javier, David Kohel, Anne
 Schilling, ...) See CategoriesCategoriesReview
    - [http://combinat.sagemath.org/patches/file/tip/categories-fixsagelib-
 nt.patch]         (positive review: Robert Bradshaw)
    updates to the sage library (import fixes, ...)
    - [http://combinat.sagemath.org/patches/file/tip/categories-fix-
 combinat-nt.patch]       (positive review: Florent)
    - [http://combinat.sagemath.org/patches/file/tip/categories-
 numberfieldvengoroso_homset-nt.patch] (reviewer: David)
    - [http://combinat.sagemath.org/patches/file/tip/categories-
 unpickle_backward_compatibility_aliases-nt.patch] (positive review:
 Florent)


  - Status and roadmap:
 http://sagetrac.org/sage_trac/wiki/CategoriesRoadMap

--

Comment:

 Replying to [comment:17 was]:
 > NOTES:
 >
 >   (1) Post the latest version here -- I don't want to mess with the
 patch server.

 I just added direct links in the description. I will post the patches
 shortly when they will be final.

 >
 >   (2) It says "Experts: please redefine this properly and/or put
 CC/RR/... in NumberFields()".  I number field is by definition a finite
 extension of QQ, but CC and RR are infinite extensions of QQ.  So we can't
 put them in that category.   Having a function
 is_NumberFieldHomsetCodomain does seem like a good workaround for now.

 Ok.

 >   (3) The function is_NumberFieldHomsetCodomain in the patch posted here
 doesn't have any documentation or doctests. Please add them.

 Oops. Will do.

 >   (4) (5) (6)

 Yes better. Will do.

 >     (6) I'm puzzled by this in your number_field_rel.py patch:
 > {{{
 >       543                 return NotImplemented
 > }}}
 >
 > What is NotImplemented? It's not defined in the number_field_rel.py file
 in sage-4.2.

 It's a builtin python object. Anyway, the function now raises a TypeError,
 per the latest _Hom_ protocol.

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/5891#comment:19>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to 
[email protected]
For more options, visit this group at 
http://groups.google.com/group/sage-trac?hl=en
-~----------~----~----~----~------~----~------~--~---

Reply via email to