#7457: improvements to quotient_ring.py
---------------------------+------------------------------------------------
Reporter: AlexGhitza | Owner: AlexGhitza
Type: enhancement | Status: needs_work
Priority: minor | Milestone: sage-4.3
Component: algebra | Keywords:
Work_issues: | Author: Alex Ghitza
Upstream: N/A | Reviewer: John Palmieri
Merged: |
---------------------------+------------------------------------------------
Changes (by jhpalmieri):
* status: needs_review => needs_work
* upstream: => N/A
Comment:
Two comments: this is not your fault, but can you fix lines 39-40 of
quotient_ring.py? Right now it says
{{{
Creates a quotient ring of the ring `R` by the ideal `I`. Variables
are
labeled by ``names``. (If the quotient ring is a quotient of a
polynomial ring.). If ``names`` isn't given, 'bar' will be appended to
the variable names in `R`.
}}}
and the parentheses and surrounding punctuation really bother me. Should
this say
{{{
Creates a quotient ring of the ring `R` by the ideal `I`. Variables
are
labeled by ``names`` (if the quotient ring is a quotient of a
polynomial ring). If ``names`` isn't given, 'bar' will be appended to
the variable names in `R`.
}}}
? Or even remove the parentheses altogether?
Second and more importantly, I'm getting doctest failures in
schemes/elliptic_curves:
{{{
The following tests failed:
sage -t -long devel/sage/sage/schemes/elliptic_curves/sha_tate.py
# 8 doctests failed
sage -t -long devel/sage/sage/schemes/elliptic_curves/padics.py #
46 doctests failed
sage -t -long
devel/sage/sage/schemes/elliptic_curves/formal_group.py # 1 doctests
failed
sage -t -long
devel/sage/sage/schemes/elliptic_curves/monsky_washnitzer.py # 3 doctests
failed
}}}
The problem seems to be the change to rings.pyx. I don't know why you
would ever want to {{{return}}} a {{{NotImplementedError}}} instead of
raising it, but that change seems to be causing the problems. So my
suggestion is to get rid of that change, make sure doctests pass, and then
perhaps open up a new ticket in which that issue is addressed.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/7457#comment:5>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=.
