#7526: polynomial_template should avoid unnecessary coercions
---------------------------+------------------------------------------------
Reporter: ylchapuy | Owner: tbd
Type: defect | Status: needs_review
Priority: major | Milestone:
Component: performance | Keywords:
Work_issues: | Author:
Upstream: N/A | Reviewer:
Merged: |
---------------------------+------------------------------------------------
Comment(by malb):
The patch looks good and applies & doctests cleanly for me. However, we
can do a little better.
On my machine I get the following:
'''Before'''
{{{
sage: R.<x> = GF(3)[]
sage: p=x^100 + x^81 + x^67 + x^33 + 1
sage: q=x^10 + x^8 + x^6 + x^3 + 1
sage: timeit('p%q')
625 loops, best of 3: 193 µs per loop
}}}
'''Patch'''
{{{
sage: R.<x> = GF(3)[]
sage: p=x^100 + x^81 + x^67 + x^33 + 1
sage: q=x^10 + x^8 + x^6 + x^3 + 1
sage: timeit('p%q')
625 loops, best of 3: 26.6 µs per loop
}}}
With my incremental reviewer patch I get:
{{{
sage: R.<x> = GF(3)[]
sage: p=x^100 + x^81 + x^67 + x^33 + 1
sage: q=x^10 + x^8 + x^6 + x^3 + 1
sage: timeit('p%q')
625 loops, best of 3: 18.2 µs per loop
}}}
So, this is a positive review if someone reviews my reviewer patch.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/7526#comment:2>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
