#7635: notebook -- make it trivial for any user to restrict the notebook server
to
only listen on certain subdomain
---------------------------+------------------------------------------------
Reporter: was | Owner: was
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-4.3
Component: notebook | Keywords:
Work_issues: | Author: William Stein
Upstream: N/A | Reviewer: Dan Drake
Merged: |
---------------------------+------------------------------------------------
Changes (by was):
* status: needs_work => needs_review
Comment:
Replying to [comment:8 ddrake]:
> Oops, I need to back up here...when I do {{{address="whatever.foo"}}},
it blocks localhost, since it's coming from 127.0.1.1 -- not 127.0.0.1. I
think the localhost stuff should be 127.0.0.0/8
(http://en.wikipedia.org/wiki/Localhost). I'll upload a micro-patch for
this.
Wow! Your localhost is 127.0.1.1? What operating system is that on? For
me on OS X and sage.math, localhost is 127.0.0.1. On Wikipedia it says
"Localhost always translates to the loopback IP address 127.0.0.1 in
IPv4." (same page you reference). That said, also according to wikipedia
using 127.0.0.0/8 is safe. Your patch has 127.0.0.1/8 by the way.
I guess your micro patch doesn't quite work because of the line {{{if
'127.0.0.1' not in subnets:}}} right above the insert line.
Also, are you sure about your patch? You say: Try
{{{notebook(address='x.y.z', subnets=['blah'])}}} But as soon as you
explicitly specify the address then Twisted only listens on that interface
and ignores localhost or any other interface (localhost is just a network
interface like any other).
So unless I'm missing something (I usually am!) we shouldn't apply your
micro patch and should change this back to "positive review". What do
you think?
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/7635#comment:10>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
