#7635: notebook -- make it trivial for any user to restrict the notebook server
to
only listen on certain subdomain
---------------------------+------------------------------------------------
Reporter: was | Owner: was
Type: enhancement | Status: positive_review
Priority: major | Milestone: sage-4.3
Component: notebook | Keywords:
Work_issues: | Author: William Stein
Upstream: N/A | Reviewer: Dan Drake
Merged: |
---------------------------+------------------------------------------------
Changes (by ddrake):
* status: needs_review => positive_review
Comment:
I've uploaded an improved version of the micro-patch.
Now I understand {{{address}}}. If you do something like
{{{
notebook(address='123.456.1.2', subnets=['123.456.0.0/16'])
}}}
(which, yes, I know is silly), then nothing we do with {{{subnets}}} will
allow access via the loopback interface, since Twisted is simply not
listening there. So getting denied access via loopback with the above is
correct behavior. OTOH, with
{{{
notebook(address='', subnets=['123.456.0.0/16'])
}}}
I think it's more reasonable to put our own "127.0.0.0/8" into
{{{subnets}}}, since the user did implicitly ask for Twisted to listen on
the loopback interface.
I see that
[http://www.debian.org/doc/manuals/reference/ch05.en.html#_the_hostname_resolution
Debian puts 127.0.1.1] into /etc/hosts. On my machine, that has the effect
of having "localhost" resolve to 127.0.0.1, and "klee" resolve to
127.0.1.1. So we should definitely support the whole 127.*.*.* range.
Now that I understand the address/interface keyword, I'm putting your
patches back to positive review. I also think we should allow 127.0.0.0/8;
what do you think of my patch? Should the help text be modified to match
the code?
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/7635#comment:13>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
