#7539: primes.p0.spkg with "prime_sieve.c" functionality
-----------------------------+----------------------------------------------
   Reporter:  GeorgSWeber    |       Owner:  rohana             
       Type:  enhancement    |      Status:  new                
   Priority:  major          |   Milestone:  sage-4.3.1         
  Component:  number theory  |    Keywords:                     
Work_issues:                 |      Author:  rohana, GeorgSWeber
   Upstream:  N/A            |    Reviewer:                     
     Merged:                 |  
-----------------------------+----------------------------------------------

Comment(by mvngu):

 From IRC:
 {{{
 06:44 < mvngu> The attachments look like a mess to me.
 06:45 < SageWWW> They are supposedly diffs
 06:45 < mvngu> I downloaded the first attachment, uncompressed it, and
 can't
                work out which patches to apply in which order.
 06:49 < SageWWW> "The first diff contains a (working) subset of the
 changes I
                  made, the second contains all changes."Leif
 06:50 < SageWWW> That is in his first email.  And he also included the
 original
 06:51 < mvngu> So Silva.c.orig is the original version. And Silva.c is the
                newer version with all changes in the diff's?
 06:51 < SageWWW> Perhaps.  It would be easier to tell if Leif added
 himself to
                  the authors section of the updated code
 06:53 < mvngu> The diff's don't look like standard diff formats. At least
 when
                I apply them with the command "patch", they failed to
 apply.
 06:56 < SageWWW> It is extra confusing that Andrew Ohana and Leif
 Leonhardy
                  both made their own updated version of Kevin Stueve's
 updated
                  version of Oliviera e Silva's code.
 06:56 < mvngu> I think if you diff Silva.c.orig against Silva.c, you get
 the
                differences in the newer version (which is Silva.c).
 }}}
 The attachments look confusing to me. So I have attached what I think is
 the sequence of patches to apply on top of the original C code version
 `Silva.c.orig`. Starting from `Silva.c.orig`, apply the three patches in
 this order:

  1. `01_Silva.patch`
  1. `02_Silva.patch`
  1. `03_Silva.patch`

 After applying the above three patches on top of `Silva.c.orig`, you get
 the file `Silva.c`. I hope my attachments would resolve some of the
 confusion.

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/7539#comment:3>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

--

You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/sage-trac?hl=en.


Reply via email to