#7440: optional valgrind-3.3.1 spkg doesn't build with newer GCC's
---------------------------------+------------------------------------------
   Reporter:  was                |       Owner:  tbd         
       Type:  defect             |      Status:  needs_review
   Priority:  major              |   Milestone:  sage-4.3.1  
  Component:  optional packages  |    Keywords:              
Work_issues:                     |      Author:  Tim Dumol   
   Upstream:  N/A                |    Reviewer:  David Kirkby
     Merged:                     |  
---------------------------------+------------------------------------------
Changes (by timdumol):

  * status:  needs_work => needs_review


Comment:

 Replying to [comment:7 drkirkby]:
 > This has a portability bug. 'uname' will will called with the '-p'
 option on any non-Linux system. But '-p' is not a POSIX option for uname.

 I do not believe this is a problem, since `uname -p` will only be called
 on Linux and Darwin platforms because of boolean logic shortcircuiting,
 e.g.:

 {{{
 [timdu...@tim-pc sage]$ if [ -z "" ] && [ -z "`error`" ]; then echo
 "Success"; fi
 bash: error: command not found
 Success
 [timdu...@tim-pc sage]$ if [ -n "" ] && [ -z "`error`" ]; then echo
 "Success"; fi
 }}}

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/7440#comment:11>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

--

You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/sage-trac?hl=en.


Reply via email to