#7440: optional valgrind-3.3.1 spkg doesn't build with newer GCC's
---------------------------------+------------------------------------------
Reporter: was | Owner: tbd
Type: defect | Status: positive_review
Priority: major | Milestone: sage-4.3.1
Component: optional packages | Keywords:
Work_issues: | Author: Tim Dumol
Upstream: N/A | Reviewer: David Kirkby
Merged: |
---------------------------------+------------------------------------------
Changes (by drkirkby):
* status: needs_review => positive_review
Comment:
First, merry Christmas to you both.
William asked me the other day to check what optional packages installed
on Solaris. Valgind did not install, but did give a helpful error message,
indicating why. That's much better than executing a command which will
fail. So I believe the fact Valgind does not work on Solaris, AIX, HP-UX
etc is a not an excuse for sloppy programming - there is enough of that in
Sage anyway!
William's use of:
{{{
elif [ `uname` = "SunOS" -a "`uname -p`" != "sparc" ]; then
}}}
in an early version of 'prereq' did cause an issue on HP-UX, with the -p
option creating problems - see #7156.
Tim's version is written slighlty different, using the preffered '&&'
instead of '-a'. The use of '-a' is deprecated and discouraged by POSIX
http://www.opengroup.org/onlinepubs/009695399/utilities/test.html
so perhaps Tim's arugument is valid. On reflection, I agree with Tim.
However, as my grandmother used to say, the proof of the pudding is in the
eating, so I tested this on HP-UX, where sage-4.2.1 is installed.
{{{
valgrind-3.5.0.p0/patches/sage.supp
Finished extraction
****************************************************
Host system
uname -a:
HP-UX hpbox B.11.11 U 9000/785 2016698240 unlimited-user license
****************************************************
****************************************************
CC Version
gcc -v
Using built-in specs.
Target: hppa1.1-hp-hpux11.11
Configured with: /tmp/gcc-4.3.3.tar.gz/gcc-4.3.3/configure --host=hppa1.1
-hp-hpux11.11 --target=hppa1.1-hp-hpux11.11 --build=hppa1.1-hp-hpux11.11
--prefix=/opt/hp-gcc-4.3.3 --with-gnu-as --without-gnu-ld --enable-
threads=posix --enable-languages=c,c++ --with-gmp=/proj/opensrc/be/hppa1.1
-hp-hpux11.11 --with-mpfr=/proj/opensrc/be/hppa1.1-hp-hpux11.11
Thread model: posix
gcc version 4.3.3 (GCC)
****************************************************
Sorry, Valgrind only works on X86/Linux, AMD64/Linux,
PPC32/Linux, PPC64/Linux and X86/Darwin 9.x
(Mac OS X 10.5.x)
real 0m0.020s
user 0m0.020s
sys 0m0.010s
sage: An error occurred while installing valgrind-3.5.0.p0
}}}
So I would have to agree, the spkg-install '''does''' work properly, even
on HP-UX. The error message is helpful too. The spkg-install does not fail
as I initially expected it would, so I'm changing this to positive review.
Dave
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/7440#comment:12>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
