#7799: install_scripts should not install M2
----------------------------+-----------------------------------------------
   Reporter:  novoselt      |       Owner:  tbd          
       Type:  defect        |      Status:  needs_review 
   Priority:  major         |   Milestone:  sage-4.3.1   
  Component:  distribution  |    Keywords:               
Work_issues:                |      Author:  John Palmieri
   Upstream:  N/A           |    Reviewer:               
     Merged:                |  
----------------------------+-----------------------------------------------
Changes (by newvalueoldvalue):

  * status:  new => needs_review
  * author:  => John Palmieri


Comment:

 Here's a patch.  I think that the problem is, in the old version, the
 command 'which M2' was executed, and if it didn't return a system error
 (meaning that M2 didn't exist), then it installed the Sage script.  The
 patch changes it so it checks if 'which M2' returns an error, and if not,
 then whether 'which M2' starts with SAGE_ROOT.  If not, then M2 is already
 installed elsewhere, so don't install the Sage script.  (Of course it does
 this for all of the scripts, not just for M2.)

 I've also added a doctest.

 We could also worry about whether M2 should be included here at all, given
 its status.  I suggest that we keep it, since if my patch works the way I
 think, we should never install the script as long as we don't distribute a
 working version of M2, but if someone fixes the spkg for it, then we don't
 have to remember to reinstate it in 'install_scripts'.

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/7799#comment:1>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

--

You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/sage-trac?hl=en.


Reply via email to