#7716: sage -coverage enhancement
-----------------------------+----------------------------------------------
   Reporter:  roed           |       Owner:  mvngu     
       Type:  enhancement    |      Status:  needs_work
   Priority:  major          |   Milestone:  sage-4.3.1
  Component:  documentation  |    Keywords:  coverage  
Work_issues:                 |      Author:  roed      
   Upstream:  N/A            |    Reviewer:            
     Merged:                 |  
-----------------------------+----------------------------------------------
Changes (by was):

  * status:  needs_review => needs_work


Comment:

 Fails to apply to sage-4.3:
 {{{
 wst...@boxen:~/build/referee/sage-4.3/local/bin$ hgimport
 http://trac.sagemath.org/sage_trac/attachment/ticket/7716/7716_coverage.patch
 --08:41:18--  http://trac.sagemath.org/sage_trac/raw-
 attachment/ticket/7716/7716_coverage.patch
            => `7716_coverage.patch'
 Resolving trac.sagemath.org... 128.208.160.197
 Connecting to trac.sagemath.org|128.208.160.197|:80... connected.
 HTTP request sent, awaiting response... 200 Ok
 Length: 58,082 (57K) [text/x-diff]

 100%[====================================================================>]
 58,082        --.--K/s

 08:41:18 (220.36 MB/s) - `7716_coverage.patch' saved [58082/58082]

 applying 7716_coverage.patch
 patching file sage-coverage
 Hunk #2 FAILED at 15
 1 out of 3 hunks FAILED -- saving rejects to file sage-coverage.rej
 patching file sage-coverage
 Hunk #1 FAILED at 0
 Hunk #4 FAILED at 622
 2 out of 4 hunks FAILED -- saving rejects to file sage-coverage.rej
 patching file sage-coverageall
 Hunk #1 FAILED at 0
 Hunk #2 FAILED at 22
 Hunk #3 FAILED at 38
 3 out of 3 hunks FAILED -- saving rejects to file sage-coverageall.rej
 abort: patch failed to apply
 }}}

 Maybe the patch is broken/corrupt?  It starts
 {{{
 # HG changeset patch
 # User David Roe <[email protected]>
 # Date 1261014209 18000
 # Node ID da454b36cda7a92a4cbee40317e86f970a04dd8e
 # Parent  e4aff87d1aa188834f14c6f4643beff69879512f
 Adds features to the sage-coverage script.

 - rewrite for modularity and easier addition of features
 ...
 }}}
 then line 604 is suddenly:
 {{{
 # HG changeset patch
 # User David Roe <[email protected]>
 # Date 1261014209 18000
 # Node ID e5314d3c2ba2b0ec34d8226ee80db4526a8a5678
 # Parent  2c17a7cee6e7b76fe67053f34c20ed7c6c33d7cb
 Adds features to the sage-coverage script.

 - rewrite for modularity and easier addition of features
 - changes the score of the file to reflect the presence or absence of a
 TestSuite.run or equivalent test.
 ...
 }}}

 which involves exactly the same changeset comment and changes to the same
 file (sage-coverage).

 Anyway, I'm pretty confused by this, and can't even referee it.

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/7716#comment:9>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

--

You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/sage-trac?hl=en.


Reply via email to