#7724: breadth/depth first search and basic connectivity for c_graphs
----------------------------+-----------------------------------------------
   Reporter:  ncohen        |       Owner:  rlm                              
       Type:  enhancement   |      Status:  positive_review                  
   Priority:  major         |   Milestone:  sage-4.3.1                       
  Component:  graph theory  |    Keywords:                                   
Work_issues:  needs rebase  |      Author:  Nathann Cohen, Yann Laigle-Chapuy
   Upstream:  N/A           |    Reviewer:  Robert Miller                    
     Merged:                |  
----------------------------+-----------------------------------------------
Changes (by newvalueoldvalue):

  * status:  needs_review => positive_review
  * author:  Nathann Cohen => Nathann Cohen, Yann Laigle-Chapuy


Comment:

 1. The iterator patch is preferable, since there are actual speed gains
 when a loop is terminated early. I've rebased the patch against sage-4.3.

 2. There is some confusion as to the function `get_vertex`. This should go
 from Python objects to ints, and in several places it is used the other
 way around. The function `vertex_label` will go from int to Python object,
 and I've switched these in the appropriate places (see
 `trac_7724-ref.patch`). I've also added an example where the vertex labels
 aren't integers.

 3. I've tested this with #7634 applied, and everything looks good with the
 fixes mentioned above.

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/7724#comment:14>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

--

You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/sage-trac?hl=en.


Reply via email to