#7249: switch the notebook's templating system to Jinja2
---------------------------+------------------------------------------------
   Reporter:  ddrake       |       Owner:  boothby   
       Type:  enhancement  |      Status:  needs_work
   Priority:  major        |   Milestone:  sage-4.3.1
  Component:  notebook     |    Keywords:            
Work_issues:               |      Author:  Dan Drake 
   Upstream:  N/A          |    Reviewer:            
     Merged:               |  
---------------------------+------------------------------------------------
Changes (by mpatel):

  * status:  needs_review => needs_work


Comment:

 V3:

   * Fixes a number of doctests.
   * `iamges` --> `images` in `cell.py`.
   * `inpit_text = input_text.decode('utf-8', str)` --> `input_text =
 input_text.decode('utf-8', 'ignore')` in `cell.py`.

 I'm not sure about the choice of `encode` / `decode` in some places.
 Should we always `decode` instances of `str` and `encode` instances of
 `unicode`?  Could you please double-check the patch?  Also, would it be
 better to write and use a helper function to do the conversions?

 Should the changes to `cell.html` be at #7786?  Isn't `div_wrap` a
 `boolean`?

 Does the change to `Worksheet.preparse` belong at #7835?

 If we're planning to use unicode "everywhere", even for the worksheet /
 cell ''system'', should we also '''consistently''' cover the relevant
 methods (and examples for) in `worksheet.py` and elsewhere?

 I apologize for my ignorance.

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/7249#comment:7>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB
-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/sage-trac?hl=en.


Reply via email to