#7786: Restructure templates to idiomatic Jinja
---------------------------+------------------------------------------------
   Reporter:  timdumol     |       Owner:  was         
       Type:  enhancement  |      Status:  needs_review
   Priority:  major        |   Milestone:  sage-feature
  Component:  notebook     |    Keywords:              
Work_issues:               |      Author:  Tim Dumol   
   Upstream:  N/A          |    Reviewer:  Mitesh Patel
     Merged:               |  
---------------------------+------------------------------------------------
Changes (by mpatel):

  * reviewer:  => Mitesh Patel


Comment:

 V8 should cover the problems above, except for deleting docbrowser cells,
 which is a known "problem" --- we don't save changes to these worksheets.
 Anyway, to the extent it counts, my review is positive, except:

  * Is `_topbar.sass` missing?  When compiling, I see
 {{{
 Sass::SyntaxError on line 29 of /.../sass/src/main.sass: File to import
 not found or unreadable: topbar.sass.
 }}}
    If I comment out the `...@import`, the generated `main.css` seems to be
 missing topbar directives.

 By the way, I removed `template_error.html` and `base_popup.html`, since
 they don't appear to be used.  I also put `set div_wrap = true` in
 `cell.html` (when printing).  I apologize for going too far, in case I
 have.

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/7786#comment:24>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB
-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/sage-trac?hl=en.


Reply via email to