#7857: Arithmetic operations in fraction fields
---------------------------+------------------------------------------------
Reporter: spancratz | Owner: spancratz
Type: enhancement | Status: needs_work
Priority: major | Milestone: sage-4.3.1
Component: algebra | Keywords: fraction field
Work_issues: | Author: spancratz
Upstream: N/A | Reviewer: John Cremona
Merged: |
---------------------------+------------------------------------------------
Comment(by spancratz):
At the moment, the following tests still fail:
{{{
sage -t devel/sage-ff/sage/combinat/sf/hall_littlewood.py
sage -t devel/sage-ff/sage/combinat/sf/macdonald.py
sage -t devel/sage-ff/sage/combinat/sf/sf.py
sage -t devel/sage-ff/sage/combinat/sf/jack.py
sage -t devel/sage-ff/sage/coding/linear_code.py
sage -t devel/sage-
ff/sage/algebras/quatalg/quaternion_algebra_element.pyx
sage -t devel/sage-ff/sage/matrix/matrix2.pyx
}}}
After taking a first look, it seems that some of these are just positive
docstring changes (e.g. a previous ``(-1)/(-1)`` which is now correctly
displayed as a ``1``), others are negative changes (e.g. a previous ``1``
now displayed as ``(1/3)/(1/3)``). However, some ``AttributeError``s are
raised for fraction field elements, suggesting that sometimes the
numerator or denominator isn't in the ring (of the fraction field).
However, *assuming* that the numerators and denominators of the input to
the arithmetic methods belong to the correct ring, I think the code should
preserve this and so I should be right to always pass ``coerce=False``. I
could pass ``coerce=True`` to fix these, but assuming I am right (which
might not be the case), this would just hide mistakes elsewhere. In any
case, I'll look at these points tomorrow.
Sebastian
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/7857#comment:7>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
