#7857: Arithmetic operations in fraction fields
---------------------------+------------------------------------------------
   Reporter:  spancratz    |       Owner:  spancratz     
       Type:  enhancement  |      Status:  needs_review  
   Priority:  major        |   Milestone:  sage-4.3.1    
  Component:  algebra      |    Keywords:  fraction field
Work_issues:               |      Author:  spancratz     
   Upstream:  N/A          |    Reviewer:  John Cremona  
     Merged:               |  
---------------------------+------------------------------------------------

Comment(by cremona):

 This looks pretty good, and I am checking it now (as it touches so many
 places I am doing a full test on both 32 and 64 bit machines).

 Two small points:
     1. If you have several "except" clauses each with the same action, you
 can combine them thus:
 {{{
     except (AttributeError, NotImplementedError, TypeError):
 }}}
    2. It's a bit perverse to call the num and den of "self" rnum and rden
 whle calling those of "right" snum and sden.   However, swapping the over
 without introducing any bugs would not be trivial!

 I will report back when the full tests have finished.

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/7857#comment:13>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB
-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/sage-trac?hl=en.


Reply via email to