#6616: [with patch; needs review] refactor heegner points code out of
ell_rational_field and support computing higher heegner points
-----------------------------+----------------------------------------------
Reporter: robertwb | Owner: was
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-4.3.1
Component: number theory | Keywords:
Work_issues: | Author:
Upstream: N/A | Reviewer: John Cremona
Merged: |
-----------------------------+----------------------------------------------
Comment(by cremona):
cremona>> The patches say they are based on 4.3 rather than 4.3.1. the
first
>> one produced one failed hunk when I applied it to 4.3.1 (see attached
>> -- looks minor).
>
was> That's in a doctest for something probably unrelated, so can be
safely
> ignored for refereeing.
Ignoring that, there was just one small thing (testing on 64-bit), namely
{{{
File "/home/jec/sage-4.3.1.alpha1/devel/sage-
tests/sage/schemes/elliptic_curves/heegner.py", line 277:
sage: hash((-7,5))
Expected:
-3713088127102618519
1817441385
Got:
-3713088127102618519
}}}
which is just because someone forgot to add the tag # 32-bit. I added
that by editing the patch, and the corrected version is now attached here.
So: positive review on 64-bit. I'll test on 32-bit when I get home
(leaving now, hope I do not get buried in the snow...)
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/6616#comment:19>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
