#3964: projective space homs do not check arguments sufficiently
----------------------------------+-----------------------------------------
   Reporter:  cremona             |       Owner:  AlexGhitza                
       Type:  defect              |      Status:  positive_review           
   Priority:  major               |   Milestone:  sage-4.3.1                
  Component:  algebraic geometry  |    Keywords:  projective space morphism 
Work_issues:                      |      Author:  Alex Ghitza, William Stein
   Upstream:  N/A                 |    Reviewer:  John Cremona              
     Merged:                      |  
----------------------------------+-----------------------------------------
Changes (by newvalueoldvalue):

  * status:  needs_review => positive_review
  * reviewer:  => John Cremona
  * author:  => Alex Ghitza, William Stein


Comment:

 Patch applies fine to 4.3.1.rc0 and tests pass.  So I'll give this a
 positive review despite the fact that (as was said) there's a lot more
 needing to be done, for example:

 {{{
 sage: S.<u,v,w> = QQ[]
 sage: C = Curve(u^2+v^2-w^2); C
 Projective Curve over Rational Field defined by u^2 + v^2 - w^2
 sage: H = C.Hom(C); H
 Set of points of Projective Curve over Rational Field defined by u^2 + v^2
 - w^2 defined over Quotient of Multivariate Polynomial Ring in u, v, w
 over Rational Field by the ideal (u^2 + v^2 - w^2)
 sage:
 sage: H([u,v,w])
 ---------------------------------------------------------------------------
 AttributeError                            Traceback (most recent call
 last)
 ...
 AttributeError: 'QuotientRingElement' object has no attribute 'degree'
 }}}

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/3964#comment:9>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB
-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/sage-trac?hl=en.


Reply via email to