#7666: Alphanumeric cell IDs, resize on paste (#2902), ESC ends introspection
(#5644), JSLint for notebook_lib.js
---------------------------+------------------------------------------------
Reporter: mpatel | Owner: was
Type: enhancement | Status: positive_review
Priority: major | Milestone: sage-4.3.1
Component: notebook | Keywords:
Work_issues: | Author: Mitesh Patel
Upstream: N/A | Reviewer:
Merged: |
---------------------------+------------------------------------------------
Changes (by timdumol):
* status: needs_review => positive_review
Comment:
Excellent work. Cleans up the library quite well.
I've rebased the patch on a new patch queue, but since the reject is just
some empty lines, I'll mark this with a positive review.
{{{
--- notebook_lib.js
+++ notebook_lib.js
@@ -4376,10 +4676,10 @@ function decode64(input) {
return output;
}
+
///////////////////////////////////////////////////////////////////
// Trash
///////////////////////////////////////////////////////////////////
-
function empty_trash() {
/*
Empties the trash folder, after asking for confirmation.
}}}
The new patch queue is:
{{{
trac_7650-sagenb_doctesting_v6.patch
trac_7650-reviewer.patch
trac_7648-missing_indent.patch
trac_7663-rstrip_prompt.patch
trac_7847-empty-trash-no-referer.patch
trac_7786-template-jinja-idiomatic.patch
trac_7863-declare_vars_aux_js_v2.patch
trac_7874-typeset_interact_labels.patch
trac_7858-key_binding_vars_v2.patch
trac_7666-alphanumeric_cell_ids_B5.patch
}}}
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/7666#comment:28>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
