#7760: sage -merge fails silently when applying patches with rejects
-----------------------+----------------------------------------------------
Reporter: mhansen | Owner: GeorgSWeber
Type: defect | Status: positive_review
Priority: major | Milestone: sage-4.3.1
Component: build | Keywords:
Work_issues: | Author: Mike Hansen
Upstream: N/A | Reviewer:
Merged: |
-----------------------+----------------------------------------------------
Changes (by craigcitro):
* status: needs_review => positive_review
Comment:
This is clearly the right fix for the problem Mike ran into, and I'm
giving it a positive review.
I'm happy to see this merged, but it brings up a question: why aren't we
checking the exit code from mercurial? A quick check of the code reveals
the issue: we use `os.popen3` inside the hg interface, which we can't
easily use to get the return code. (Or, at least, I don't know how to do
it.) Maybe we should file an enhancement ticket to rewrite those lines to
use `subprocess.Popen`, and correctly give back the return code?
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/7760#comment:2>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
