#7973: Documentation for submitting a patch is overly confusing
----------------------------------+-----------------------------------------
Reporter: gaer | Owner: mvngu
Type: defect | Status: needs_review
Priority: major | Milestone: sage-4.3.1
Component: documentation | Keywords:
Work_issues: badly formed patch | Author: Arthur Gaer
Upstream: N/A | Reviewer: Minh Van Nguyen
Merged: |
----------------------------------+-----------------------------------------
Changes (by newvalueoldvalue):
* reviewer: => Minh Van Nguyen
* author: => Arthur Gaer
Comment:
I'm OK with the proposed changes in
[http://trac.sagemath.org/sage_trac/attachment/ticket/7973/13639.2.patch
13639.2.patch]. I have attached a reviewer patch
[http://trac.sagemath.org/sage_trac/attachment/ticket/7973/trac_7973-reviewer.patch
trac_7973-reviewer.patch], which fixes some typos. The attachment
[http://trac.sagemath.org/sage_trac/attachment/ticket/7973/13639.2.patch
13639.2.patch] contains some tab characters, which don't look good when
you view the HTML version of the Developer's Guide, i.e. only the
corresponding section in the Developer's Guide. Try to avoid tabs as much
as possible in patches. If you're OK with the reviewer patch, then the
whole ticket gets a positive review.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/7973#comment:5>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
