#7921: Categories for extension types via __getattr___
---------------------------------+------------------------------------------
   Reporter:  nthiery            |       Owner:  nthiery   
       Type:  enhancement        |      Status:  needs_info
   Priority:  major              |   Milestone:            
  Component:  categories         |    Keywords:            
     Author:  Nicolas M. ThiƩry  |    Upstream:  N/A       
   Reviewer:  Robert Bradshaw    |      Merged:            
Work_issues:                     |  
---------------------------------+------------------------------------------
Changes (by robertwb):

  * status:  needs_review => needs_info


Comment:

 The attribute lookup code looks good. Most of the other changes are minor,
 though changing loads/dumps to running tests is an independent change is
 seems.

 sage/groups/group.pyx
 {{{
     def __call__(self, x): # NT: doesn't this get in the way of the
 coercion mechanism?
 }}}

 Groups are not yet converted over to the new coercion model, and are a
 mess in general.

 In sage/modular/abvar/abvar.py, you removed the method but kept the
 docstring floating there. Those tests should be kept, but probably not put
 there.

 sage/modules/free_module.py - It'd be good to test the category of non-
 vector space.

 Could you explain the changes to sage/structure/sage_object.pyx?

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/7921#comment:7>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB
-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/sage-trac?hl=en.


Reply via email to