#7921: Categories for extension types via __getattr___
---------------------------------+------------------------------------------
Reporter: nthiery | Owner: nthiery
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-4.3.2
Component: categories | Keywords:
Author: Nicolas M. Thiéry | Upstream: N/A
Reviewer: Robert Bradshaw | Merged:
Work_issues: |
---------------------------------+------------------------------------------
Changes (by nthiery):
* milestone: => sage-4.3.2
Comment:
Replying to [comment:7 robertwb]:
> The attribute lookup code looks good. Most of the other changes are
minor, though changing loads/dumps to running tests is an independent
change is seems.
Well, I actually only added 2/3 of them, mostly as an attempt to catch
possible introduced issues. The others were already there, and needed to
be updated due to all the new (often failing) tests coming from
categories.
> sage/groups/group.pyx
> {{{
> def __call__(self, x): # NT: doesn't this get in the way of the
coercion mechanism?
> }}}
>
> Groups are not yet converted over to the new coercion model, and are a
mess in general.
Ok. Shouldn't this def be removed, so as not to prevent groups inheriting
from Group to progressively get converted to the coercion model? Sure,
that should be a separate patch. As for the comment above: I just can't
prevent myself from adding comments in the code when I stumble on strange
stuff. I can remove it if you prefer.
> In sage/modular/abvar/abvar.py, you removed the method but kept the
docstring floating there. Those tests should be kept, but probably not put
there.
Oops, fixed.
> sage/modules/free_module.py - It'd be good to test the category of non-
vector space.
Done.
> Could you explain the changes to sage/structure/sage_object.pyx?
I improved the description on top of the patch, including a comment about
this.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/7921#comment:10>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
