#6625: manually removing executable bits doesn't work
-------------------------------------+--------------------------------------
Reporter: mvngu | Owner: cwitty
Type: defect | Status: needs_review
Priority: minor | Milestone: sage-4.3.1
Component: misc | Keywords:
Author: Willem Jan Palenstijn | Upstream: N/A
Reviewer: Minh Van Nguyen | Merged:
Work_issues: |
-------------------------------------+--------------------------------------
Changes (by newvalueoldvalue):
* reviewer: => Minh Van Nguyen
* author: => Willem Jan Palenstijn
Comment:
The attachment
[http://trac.sagemath.org/sage_trac/attachment/ticket/6625/scripts_6625_no_x_bit.patch
scripts_6625_no_x_bit.patch] fails to apply against Sage 4.3.1.rc1:
{{{
[mv...@mod bin]$ pwd
/dev/shm/mvngu/sage-4.3.1.rc1/local/bin
[mv...@mod bin]$ hg qimport http://trac.sagemath.org/sage_trac/raw-
attachment/ticket/6625/scripts_6625_no_x_bit.patch
adding scripts_6625_no_x_bit.patch to series file
[mv...@mod bin]$ hg qpush
applying scripts_6625_no_x_bit.patch
patching file sage-make_devel_packages
Hunk #1 FAILED at 135
1 out of 1 hunks FAILED -- saving rejects to file sage-
make_devel_packages.rej
patch failed, unable to continue (try -v)
patch failed, rejects left in working dir
errors during apply, please fix and refresh scripts_6625_no_x_bit.patch
[mv...@mod bin]$ cat sage-make_devel_packages.rej
--- sage-make_devel_packages
+++ sage-make_devel_packages
@@ -136,6 +136,8 @@
rm -rf $SCRIPTS
mkdir $SCRIPTS
chmod +x sage-*
+chmod -x sage-README-osx.txt sage-banner sage-gdb-commands
+chmod -x sage-maxima.lisp sage-verify-pyc
chmod +x dsage_*
rm sage-*~
}}}
The failure results from #7975, which removes dsage from Sage and the
patches on #7975 have been merged in Sage 4.3.1.rc1. The guilty line from
[http://trac.sagemath.org/sage_trac/attachment/ticket/6625/scripts_6625_no_x_bit.patch
scripts_6625_no_x_bit.patch] is:
{{{
139 141 chmod +x dsage_*
}}}
Essentially the patch looks good. I have rebased it against Sage
4.3.1.rc1, so only my rebase
[http://trac.sagemath.org/sage_trac/attachment/ticket/6625/trac_6625-no-x-bit.patch
trac_6625-no-x-bit.patch] needs reviewing.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/6625#comment:2>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
