#4339: modular forms -- incorporate Nils Skoruppa's code for computing
generators
for the ring of modular forms of given level
-----------------------------+----------------------------------------------
Reporter: was | Owner: craigcitro
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-4.3.2
Component: modular forms | Keywords:
Author: | Upstream: N/A
Reviewer: | Merged:
Work_issues: |
-----------------------------+----------------------------------------------
Changes (by davidloeffler):
* status: new => needs_review
* upstream: => N/A
Comment:
Can I suggest closing this ticket? I independently fixed the code for the
ring of modular forms last year, and it got committed as part of #5727
(changeset 11961). I've since looked at Nils' code and it seems that he
and I independently fixed the same bug in more or less the same way.
Certainly find_generators.py now works, and has extensive doctests and
passes them all.
I'm setting this to "needs review" (if you like, I'm asking for a review
for the empty patch).
David
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/4339#comment:4>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
