#8038: email address validator does not accept + in addresses
-------------------------+--------------------------------------------------
   Reporter:  ddrake     |       Owner:  was         
       Type:  defect     |      Status:  needs_review
   Priority:  major      |   Milestone:  sage-4.3.2  
  Component:  notebook   |    Keywords:              
     Author:  Dan Drake  |    Upstream:  N/A         
   Reviewer:             |      Merged:              
Work_issues:             |  
-------------------------+--------------------------------------------------
Changes (by newvalueoldvalue):

  * status:  new => needs_review
  * author:  => Dan Drake


Comment:

 Patch up, please review. I tested this in a separate script, as I don't
 know how to run doctests for the notebook. But it's just running a regexp
 test on a string, so It Should Work.

 One issue is that we are still rejecting a lot of valid email addresses:
 http://tools.ietf.org/html/rfc3696#section-3. But we are accepting some
 invalid addresses, since we're not checking for maximum length, or two
 consective periods, or beginning with a period, or...

 Personally, coming up a regexp that exactly captures the RFC's
 requirements is a rabbit hole I don't want to go down, but if anyone else
 wants to try, feel free to upload a patch!

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/8038#comment:1>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/sage-trac?hl=en.

Reply via email to