#8099: pari fails to build in Open Solaris x64 as 64 bit if CFLAGS is not set
----------------------------+-----------------------------------------------
   Reporter:  jsp           |       Owner:  drkirkby    
       Type:  defect        |      Status:  needs_review
   Priority:  major         |   Milestone:  sage-4.3.2  
  Component:  solaris       |    Keywords:              
     Author:  Jaap Spies    |    Upstream:  N/A         
   Reviewer:  David Kirkby  |      Merged:              
Work_issues:                |  
----------------------------+-----------------------------------------------
Changes (by drkirkby):

  * reviewer:  => David Kirkby


Comment:

 The comment in SPKG.txt is inaccurate, as the patch is not specific to
 Open Solaris.

  A more accurate comment would be.

  * #8099 Ensures the compiler flag -m64 is added at any time SAGE64 was
  set to "yes" - previously this was only happening on OS X. This should
 aid
  building 64-bit on any platform, although it has only been tested on Open
  Solaris.

 It's far better to open a ticket for the bug first, before trying to fix
 it. Then the ticket number can be placed in the comments in SPKG.txt.

 It would be good to see some evidence the patch actually works. Such as
 byshowing the output of the 'ldd' command, that the library and/or binary
 is now a 64-bit one. For some packages, it is unnecessary to add -m64 and
 forothers, adding it does not generate 64-bit binaries. For zlib, adding
 -m64 stops the build of shared libraries.

 Dave

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/8099#comment:2>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/sage-trac?hl=en.

Reply via email to